Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Upgrade so Oyente can run with Python2 & Python3 #318

Open
vietlq opened this issue Apr 27, 2018 · 5 comments
Open

Upgrade so Oyente can run with Python2 & Python3 #318

vietlq opened this issue Apr 27, 2018 · 5 comments

Comments

@vietlq
Copy link
Contributor

vietlq commented Apr 27, 2018

Currently Oyente supports only Python 2.7 which is being phased out soon. Time to upgrade. Most of changes are simply adding parentheses to print x => print(x).

The process is rather simple: https://docs.python.org/2/library/2to3.html

If you are OK @luongnt95 I can help to do this & create a PR.

@vietlq
Copy link
Contributor Author

vietlq commented Apr 27, 2018

@luongnt95 Also web3.py requires Python >= 3.5 and < Python 4, so basically the tool itself requires 2 different versions of Python to run: 2.7 for Oyente and 3.5, 3.6 for web3.py. That's really unclean and I suggest to migrate to Python3 and fully use Python 3.5 for additional benefit for type annotation for safety: https://www.python.org/dev/peps/pep-0484/

Happy to help with migration bit by bit.

@luongnt95
Copy link
Contributor

Oyente currently uses six package to support both python2 and python3. And Yeah, the installation has the problem with web3 when the py2.7 version of web3 is deprecated now. Just feel free to make a PR

@suhabe
Copy link

suhabe commented May 11, 2018

@luongnt95 Is it possible to build oyente from source at the moment, given the web3/py2.7 issue?

@luongnt95
Copy link
Contributor

@suhabe I think this #301 can help at the moment

@lazzarello
Copy link
Contributor

#336 should address this using the Ubuntu update-alternatives system. Check the Dockerfile for references or just run the code in an image built from that Dockerfile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants