Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in setProps #69

Closed
just-boris opened this issue Dec 11, 2015 · 1 comment
Closed

Inconsistency in setProps #69

just-boris opened this issue Dec 11, 2015 · 1 comment
Labels
bug

Comments

@just-boris
Copy link
Contributor

setProps(newProps) on ReactWrapper replaces all props with a passed new one.

setProps(newProps) on ShallowWrapper merges it with exsisting.

I think that ReactWrapper should merge props as well because it is more useful and similar how React's setState works.
@lelandrichardson
Copy link
Collaborator

good catch. This should be fixed... I'll put up a fix this weekend.

@goatslacker goatslacker mentioned this issue Jan 5, 2016
Merged
@lelandrichardson lelandrichardson mentioned this issue Jan 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@just-boris @lelandrichardson