Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdom dependency? #73

Closed
jakemmarsh opened this issue Dec 14, 2015 · 2 comments
Closed

jsdom dependency? #73

jakemmarsh opened this issue Dec 14, 2015 · 2 comments

Comments

@jakemmarsh
Copy link

I'm just curious as to why jsdom is required for the full rendering. I understand the need for a DOM, but what about in environments in which a DOM already exists? In our current architecture, we're running our tests directly in the browser via Karma.

I do see that jsdom is an optional dependency, and that its require statement is wrapped in a try/catch. Does this mean that it would still work if you're using some alternative DOM? If so, then just the docs are misleading.

@MattKunze
Copy link

Yeah, we definitely want to be able to use the native DOM when running tests in the browser

@lelandrichardson
Copy link
Collaborator

Agreed 100%. I hope this will be accomplished with this PR: #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants