Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror front camera #13

Merged
merged 8 commits into from Jul 22, 2019
Merged

Mirror front camera #13

merged 8 commits into from Jul 22, 2019

Conversation

blurtime
Copy link
Collaborator

This little one-liner mirrors the front camera videos which before didn't look like the preview while recording (what I was talking about in the issue):
connection.isVideoMirrored = (connection.isVideoMirroringSupported && device.position == .front && mirrorFrontCamera)
mirrorFrontCamera could be made accessible to the user but I didn't bother doing this since that would mean, one would also have to rewrite the createCamView() function, add this variable to the HybridCamView class and I only need it mirrored. Just an idea... Works without mirrorFrontCamera, too, of course.

I also changed the standard camera to .front. But that's not important.

@eonist
Copy link
Owner

eonist commented Jul 22, 2019

Maybe we should just mirror it by default? I'm not a fan of adding additional state to classes if its not needed. State complexities architecture and maintainability.

@blurtime
Copy link
Collaborator Author

Sounds great! All the social network apps everyone uses also do it so I guess it shouldn't be bad.
I haven't checked this yet but there are some weird errors occurring since I changed the standard camera to .front but it might be related to a couple of other changes I have made so maybe only take the one-liner if you merge it for now :) I'll check tomorrow what is causing these errors...

@eonist eonist merged commit bde7041 into eonist:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants