Tapping on the "1.0x" button doesn't do anything

[mathieut]

I started running the sample code, and realized that tapping on "1.0x" to change cameras doesn't do anything (just refreshes the current view).

[eonist]

Works on my iPhone 11 Pro max.

Try to see if the handlers in this file gets called on your setup:
https://github.com/eonist/HybridCamera/blob/master/Sources/HybridCamera/HybridCamView/HybridCamView%2BHandler.swift

Remember you have to try this on an actual device. since it needs to use the camera etc

[mathieut]

The function gets called when the app starts, and every time I tap on the lens/zoom button, the same thing happens:

zoomSwitcher.onSwitch: 1 deviceType: AVCaptureDeviceType(_rawValue: AVCaptureDeviceTypeBuiltInWideAngleCamera)
zoomSwitcher.onSwitch: 1 deviceType: AVCaptureDeviceType(_rawValue: AVCaptureDeviceTypeBuiltInWideAngleCamera)

I'm on iOS 14.7.1 and iPhone 12 Pro.

[eonist]

Right.
in this file: https://github.com/eonist/HybridCamera/blob/master/Sources/HybridCamera/HybridCamView/HybridCamView%2BHandler.swift

On these lines:

Swift.print("zoomSwitcher.onSwitch: \(focalType.rawValue) deviceType: \(deviceType)")
try? self.camView.toggleCameraPosition(for: self.topBar.flipButton.toggle ? .front : .back, deviceType: deviceType)

change the try? to:

do {
   try self.camView.toggleCameraPosition(for: self.topBar.flipButton.toggle ? .front : .back, deviceType: deviceType)
}
catch {
    print(error) // see what error you get
}

[mathieut]

I'm not getting any error:

Swift.print("⚠️️ zoomSwitcher.onSwitch: \(focalType.rawValue) deviceType: \(deviceType)")
//try? self.camView.toggleCameraPosition(for: self.topBar.flipButton.toggle ? .front : .back, deviceType: deviceType)
         do {
            try self.camView.toggleCameraPosition(for: self.topBar.flipButton.toggle ? .front : .back, deviceType: deviceType)
         }
         catch {
            print("⚠️️ ERROR Asked:")
            print(error) // see what error you get
         }

This is what I see in the UI on my iPhone 12 Pro:

But this is working fine on my old iPhone XS and I am seeing both 1.0x and 2.0x buttons in the UI.

[eonist]

Right. The lib doesn't support iPhone 12 yet. Needs an update here to support iPhone 12 here:

https://github.com/eonist/ZoomSwitcherKit/blob/2f686c2aa53715c82f5e7ff109edf6907c52c99f/Sources/ZoomSwitcherKit/BackCameraType/BackCameraType%2BExtension.swift#L36

I guess iPhone 12 has the same camera setup as iPhone 11. So should be just an update to device enum and adding it in the case.

Feel free to add a PR.

[mathieut]

I created a PR. I couldn't test it in HybridCamera until it is accepted so I am not 100% that it will work.

[eonist]

Looks good to me 👌

[eonist]

For another time: You can always point the SPM dep to your own fork, when testing new stuff etc.

[eonist]

Thanks

[eonist]

Btw. I would include ZoomKit as a local dependency. I didn't know this was possible before. But it would simplify things. Just a suggestion ✌️

[mathieut]

What's the benefit of this?

[eonist]

You can make edits directly to the sub module.