Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of embedding layer and pooling needed #74

Open
Alicegaz opened this issue Jul 21, 2022 · 1 comment
Open

Separation of embedding layer and pooling needed #74

Alicegaz opened this issue Jul 21, 2022 · 1 comment

Comments

@Alicegaz
Copy link

There is a package pooling which stores everything that can be used independently to process output feature maps coming from backbone. However, embedding layers can utilize different poolings and I suggest the following hierarchy:

backbones
emb_layers
heads
modules
    blocks
    bricks
    layers
        activations
        normalizations
        poolings
    necks

Top level contains components that are used in a task, here embedding_layer should replace POOLINGS.

@PososikTeam
Copy link
Collaborator

You can write your own POOLING class with different poolings. For example you need Average Pooling with Linear layer, so we wrote PoolingLinear that exactly do this. So the thing what you suggest it is just renaming POOLING to EMB_LAYER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants