Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ccc PublicKey prefix of other fork chains #130

Closed
fanyinghao opened this issue Dec 26, 2019 · 5 comments
Closed

Support ccc PublicKey prefix of other fork chains #130

fanyinghao opened this issue Dec 26, 2019 · 5 comments

Comments

@fanyinghao
Copy link

Other fork chain would change publickey prefix, so it's better to enable the customize the defined in https://github.com/eoscanada/eos-go/blob/master/ecc/pubkey.go#L17

@fanyang1988
Copy link
Contributor

@fanyinghao the PublicKeyPrefixCompat is a just a tag for public key, in https://github.com/codexnetwork/codexio-go which is a fork of eos-go for codex.io, i change the PublicKeyPrefixCompat to a value to make it can be customize because codex.io can customize main names in chain, but i think it is not a good way, for most times, just replace the prefix compat to EOS is a more flexible way.

@maoueh
Copy link
Contributor

maoueh commented Jan 22, 2020

Interesting. Will need to think about this, going from const PublicKeyPrefixCompat to var PublicKeyPrefixCompat so you could update the prefix are runtime.

@fanyinghao
Copy link
Author

@maoueh Agreed. A variable definition is reasonable.

@maoueh maoueh closed this as completed in 0a51422 Mar 16, 2020
@fanyinghao
Copy link
Author

Any update?

@maoueh
Copy link
Contributor

maoueh commented Mar 18, 2020

Pushed the changes 2 days ago on master branch.

The master branch contains some breaking changes not yet fully documented. The changes are that we added a context.Context parameter to all calls that could be cancelled throughout their operation lifetime.

That is all API calls as well as some signing functions and more.

You can check this commit eoscanada/eosc@76d29d2 on eosc project that updated our EOSIO CLI toolkit to latest version of eos-go for how to perform the update until we release completely an updated version (in the upcoming weeks, definitely not in the upcoming 2 for now however, we have another big project we are working on).

This is resolved IMO, hence the closed issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants