Repo cleanup and EOS EVM rename #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
changed the title
arhag
changed the title
elmato
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #392, but not a full resolution of the issue.
Removes
product,docs/pmo, andstakingcontractdirectories.trustevm-noderenamed toeos-evm-node.trustevm-rpcrenamed toeos-evm-rpc. Options for those programs that referenced Trust EVM are changed to instead reference EOS EVM.Replace references to Trust EVM in code and documentation to EOS EVM. The Trust seal engine has intentionally not been changed. The secrets and GitHub app for CICD still reference Trust for now and will be changed later.
Updates silkworm submodule with renames in the ChainConfig.
For some reason, the renames in the silkworm ChainConfig caused the compiled contract to change and in fact consume 32 more bytes of data. Since we had previously configured the stack size to as high as possible before causing the data to exceed the 64 KiB WASM page limit, this required me to reduce the stack size by 32 bytes. (As part of resolving #455 we should sure we leave a good safety margin going forward so we don't keep running into this issue every time we make a tiny change to contract to cause it to use a little bit more data.)