Created new parameter syncCall for RFWebServiceCall attribute #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d with proper code modifications and test
# By Yuru Taustahuzau (3) and Evgenii Kamyshanov (2) # Via Yuru Taustahuzau (5) and Evgenii Kamyshanov (1) * 'master' of https://github.com/epam/road-ios-framework: Removing obsolete info from web service docs NSMutableString(RFStringFormatter) refactoring Adding concurentAuth method to public interface #329 Fixing implicit body passing for PUT method #332 Minor fixes for code review #66 Conflicts: Framework/ROADCore/ROADCore.xcodeproj/project.pbxproj Framework/ROADWebService/ROADWebService.xcodeproj/project.pbxproj Framework/ROADWebService/ROADWebserviceTest/Classes/RFConcreteWebServiceClient.h Framework/ROADWebService/ROADWebserviceTest/RFWebServiceTest.m
2) cheating Simian
| outputPaths = ( | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "\"${SRCROOT}/../Pods/Pods-ROADCore-resources.sh\"\n"; | ||
| showEnvVarsInLog = 0; | ||
| shellScript = "\"${PODS_ROOT}/libObjCAttr/tools/binaries/ROADAttributesCodeGenerator\" -src=\"${SRCROOT}/${TARGET_NAME}\" -src=\"${PODS_ROOT}\" -dst=\"${SRCROOT}/${TARGET_NAME}/ROADGeneratedAttributes/\""; |
There was a problem hiding this comment.
@AlexeyAfanasyev Why do we have ${SRCROOT}/${TARGET_NAME}. Please, replace it with just ${SRCROOT}
There was a problem hiding this comment.
It's not me, it's ROADConfigurator.rb
|
@AlexeyAfanasyev Test for sync call fails too. Please, fix it. |
|
@AlexeyAfanasyev also, when you will be done, please, squash all these commits into 1 |
|
Changes merged within #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new parameter syncCall for RFWebServiceCall attribute that force web service request to perform synchronously with the thread it was created from.