Handle carriage returns in lines()

Closes #305 #335
esamattis · Dec 21, 2014 · b217645 · b217645
1 parent ce7693c
commit b217645
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lines.js b/lines.js
@@ -1,4 +1,4 @@
 module.exports = function lines(str) {
   if (str == null) return [];
-  return String(str).split('\n');
+  return String(str).split(/\r?\n/);
 };
diff --git a/test/strings.js b/test/strings.js
@@ -533,6 +533,8 @@ $(document).ready(function() {
     deepEqual(_('').lines(), ['']);
     deepEqual(_(null).lines(), []);
     deepEqual(_(undefined).lines(), []);
+    deepEqual(_('Hello\rWorld').lines(), ['Hello\rWorld']);
+    deepEqual(_('Hello\r\nWorld').lines(), ['Hello', 'World']);
   });
 
   test('String: pad', function() {