Optimize Levenshtein implementation #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var curCol = nextCol; | ||
|
|
||
| // substution | ||
| nextCol = prevRow[j] + ( (str1.charAt(i) === str2.charAt(j)) ? 0 : 1 ); |
There was a problem hiding this comment.
The ternary is optional here; coercing to a boolean will work as well
|
/cc @stoeffel any chance of getting this in and releasing a 3.0.4? |
|
@megawac sure I will have a look at this tomorrow and publish a new release. |
|
how about we link to hiddentao (in the readme) since this is directly from his implementation? |
|
otherwise LGTM. I will check it once again this evening and then hopefully have time to pump the version. |
stoeffel
added a commit
that referenced
this pull request
Jun 5, 2015
Optimize Levenshtein implementation
|
@megawac I published 3.1.0 |
|
Sweetness thanks! |
|
Just had to publish again since I accidentally pushed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is directly from https://github.com/hiddentao/fast-levenshtein
Before this change:
After:
Relevant jsperf: http://jsperf.com/levenshtein-distance/22 (I experimented with some of the others but this one had by far the best performance in node)