do not escapeHTML() characters that are not HTML special characters

[Mithgol]

The method escapeHTML() is said to escape HTML special characters.

However, it also escapes ¢, £, ¥, €, ©, ®. These characters do not have any special meaning in HTML and thus their conversion (in my opinion) does not bring any real benefits but only unnecessarily lengthens a string and wastes processing power.

This pull request prevents their further escaping by partially reverting #417. The issue #301 remains fixed because the unescapeHTML() method is not altered.

[stoeffel]

I actuality don't think this hurts and can see a little benefit for users. I even consider adding some other characters (i.e. ü, ä, ö). @epeli what do you think about this?

[Mithgol]

can see a little benefit for users

What's the use case?

[stoeffel]

What's the use case?

I don't have a use case at hand 😳. Maybe @srmelody who wrote #417 has a use case.

But still, I don't see a down side to the current implementation and I don't think it's a big performance issue.

[megawac]

Underscore's and lodash's escape function only handle the HTML entities required. However, on second thought, most of this may be better placed in a speciality library like https://github.com/mathiasbynens/he

[Mithgol]

There weren't any further discussion in seven months and thus I can conclude that the patch is unlikely to be accepted.

This pull request is now closed, I worked around it by using .escape() from Underscore as @megawac recommended.