Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decamelize implemented, tested and documentation updated #467

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dgolman
Copy link

@dgolman dgolman commented Dec 17, 2015

This is a pull request to add the decamelize feature requested by @stoeffel in #407

Added file decamelize.js, tests, and updated documentation.

@stoeffel
Copy link
Collaborator

Hi, thanks for the PR.
The following tests is what I would expect if you pass an empty string as the separator.

  equal(decamelize('theDecamelizeStringMethod_', ''), 'thedecamelizestringmethod_');

but the result is:

AssertionError: 'the_decamelize_string_method_' == 'thedecamelizestringmethod_'
+ expected 
- actual

+"thedecamelizestringmethod_"
-"the_decamelize_string_method_"

@dgolman
Copy link
Author

dgolman commented Dec 18, 2015

@stoeffel - Great point. I didn't think about that case. The culprit for that is this separator || '_'

I will change it to reflect the test case you just presented.

@stoeffel
Copy link
Collaborator

Could you squash your commits and remove the dist -file from the commit?
Otherwise this LGTM. @epeli are you good on this?

@esamattis
Copy link
Owner

It's cool!

Golman and others added 3 commits January 13, 2016 05:11
@stoeffel
Copy link
Collaborator

@dgolman could you also squash your commits to one?
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Golman and others added 2 commits January 14, 2016 12:52
Removing dist artifact to follow pull request guidelines

fixed empty string test fail

decamelize implemented, tested and documentation updated

Removing dist artifact to follow pull request guidelines

fixed empty string test fail

removing dist folder
@dgolman
Copy link
Author

dgolman commented Jan 14, 2016

@stoeffel I think the squash worked this time. Check it out.

@stoeffel
Copy link
Collaborator

Nope it didn't work. but I will do it for you as soon as I have time. Thanks for the PR.

@dgolman
Copy link
Author

dgolman commented Jan 14, 2016

The latest commit has all the commits in it. Just curious what I missed for
future reference.

On Thursday, January 14, 2016, Christoph Hermann notifications@github.com
wrote:

Nope it didn't work. but I will do it for you as soon as I have time.
Thanks for the PR.


Reply to this email directly or view it on GitHub
#467 (comment)
.

@stoeffel
Copy link
Collaborator

You can squash the commits into one and force push it to the branch so only one commit appears. I think I have once seen a nice guide. I will check and send you the link

@stoeffel
Copy link
Collaborator

@stoeffel stoeffel mentioned this pull request Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants