Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split default tasks from core #647

Open
tharvik opened this issue Mar 5, 2024 · 1 comment
Open

split default tasks from core #647

tharvik opened this issue Mar 5, 2024 · 1 comment
Assignees

Comments

@tharvik
Copy link
Collaborator

tharvik commented Mar 5, 2024

currently, most tasks are hardcoded inside discojs-core, which looks to me as out of place: it kinda encourage people to expect that it will always contains theses tasks thus directly depending on it & it also mixes where the tests of theses tasks are with the core code (it is kinda done in server eventhough it's not really the correct place to do it).

splitting theses in a new package, @epfml/discojs-tasks would allow for easier adding/modifing/removing of tasks, and have a dedicated place for testing theses. we would also be able to store raw data (such as image or models) directly there.

@tharvik tharvik self-assigned this Mar 5, 2024
@JulienVig
Copy link
Collaborator

Before refactoring the tasks I think it is important for us to define what's the purpose of tasks in Disco and what they are, especially what are the use cases for pre-defined tasks and custom tasks. And how LLM use would fit in those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants