Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django_dynamic_preferences #1178

Open
1 of 4 tasks
jeriox opened this issue Jan 12, 2024 · 0 comments
Open
1 of 4 tasks

Remove django_dynamic_preferences #1178

jeriox opened this issue Jan 12, 2024 · 0 comments
Labels
[C] refactoring refactors code without changing functionality dependencies Pull requests that update a dependency file [P] minor features or bugs that can wait for some more time

Comments

@jeriox
Copy link
Contributor

jeriox commented Jan 12, 2024

As the library is not maintained very well, it already caused us a lot of headaches and we needed some customization, we want to get rid of it altogether.

This includes finding alternatives for all of our current usages:

  • User notifications settings -> moved to the user profile as of improve notification framework #1143
  • event type settings -> could become proper fields on the model or a JSON field for all settings on the model
  • global settings -> probably a new InstanceSetting model that acts as a key-value store
  • internal settings (last run of cronjob etc)

In a second step, we would need to remove the data migrations created for the usages above after a release to be able to remove the dependency.

@jeriox jeriox added [P] minor features or bugs that can wait for some more time dependencies Pull requests that update a dependency file [C] refactoring refactors code without changing functionality labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] refactoring refactors code without changing functionality dependencies Pull requests that update a dependency file [P] minor features or bugs that can wait for some more time
Projects
None yet
Development

No branches or pull requests

1 participant