Add --bad and --modules Argument to find-ppr.py #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @epi052 !
I noticed the
find_ppr
script has a hard coded set of BADCHARS, which might not be applicable to all targets. Rather than manually modifying it each time, I made badchars a command-line argument so it can be set dynamically. Additionally, I movedmodules
from a positional argument to a flag in order to support this. The new usage is:Hope this is useful, thanks!