Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge component #18

Closed
17 tasks done
asvae opened this issue Sep 8, 2019 · 3 comments
Closed
17 tasks done

Badge component #18

asvae opened this issue Sep 8, 2019 · 3 comments
Assignees
@Kreezag
Milestone
1.0

Comments

@asvae
Copy link
Member

asvae commented Sep 8, 2019 •
edited by Kreezag

Docs

Props

  • transparent: Boolean
  • multiLine: Boolean
  • label: [String, Number]
  • bottom: Boolean
  • left: Boolean
  • overlap: Boolean
  • color: String - use theme plugin
  • textColor: String - use theme plugin
  • dot: boolean
  • visibleEmpty: boolean - should show badge when no value is passed (default behaviour is hide).

Design

  • Transition on change (on value change, on disappearing, changing to dot etc.
  • Present to @xx13 after finishing.

Notes

  • Native events are to be propagated
  • content could be passed via slot or via label prop. Slot has priority if both are declared.
  • Badge should be visible when no value is passed.
  • Should allow to be used on same level as text goes (see quasar ref). Add needed prop to issue and component.

Refs

Author
@asvae asvae mentioned this issue Sep 8, 2019
Closed
11 tasks
@AlexanderBoriskin AlexanderBoriskin mentioned this issue Sep 25, 2019
Closed
17 tasks
@asvae asvae added this to the 1.0 milestone Sep 30, 2019
@Kreezag Kreezag self-assigned this Oct 1, 2019
@asvae
Copy link
Member Author

asvae commented Oct 8, 2019

@Kreezag please don't move anything from Backlog to New issues.
Backlog is ready for implementation issues (past research process), New issues are not.

@Kreezag Kreezag mentioned this issue Oct 8, 2019
Merged
@xx13
Copy link

xx13 commented Oct 8, 2019

@Kreezag @asvae it looks good!

  1. I'd rather have 'Danger' as a default badge value rather than Primary Green.
  2. Can we have 'Dot' style totally round — right now it looks like a square with rounded corners.
  3. Outline style has issues with all colors except for the primary one when text color changes from white to green, but all other text notifications remain white.
  4. Slider control has a bug — its pin is stuck on the left.

Meanwhile I'm preparing the way we can present this component.

@Kreezag
Copy link
Contributor

Kreezag commented Oct 10, 2019 •
edited

@Kreezag @asvae it looks good!

  1. I'd rather have 'Danger' as a default badge value rather than Primary Green.
  2. Can we have 'Dot' style totally round — right now it looks like a square with rounded corners.
  3. Outline style has issues with all colors except for the primary one when text color changes from white to green, but all other text notifications remain white.
  4. Slider control has a bug — its pin is stuck on the left.

Meanwhile I'm preparing the way we can present this component.

Outline badges its removed.
All fixed

@asvae asvae closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kreezag Kreezag

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@asvae @Kreezag @xx13