Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradients #28

Closed
asvae opened this issue Sep 23, 2019 · 0 comments · Fixed by #52
Closed

Fix gradients #28

asvae opened this issue Sep 23, 2019 · 0 comments · Fixed by #52
Assignees
Labels
BUG Something isn't working
Milestone

Comments

@asvae
Copy link
Member

asvae commented Sep 23, 2019

Written by @xx13

Colours, Gradients, Zeplin

Current version has gradients that consist of 2 colours: an original one and a modified version. That works for all main colours, except for the green (oops).

Two Green Colours

For some reason green gradient has a slightly different green shade on the right, and I think that caused some confusion about the way gradients should be built though there are no drastic visual differences. Instead of #40e583 colour #23e066 was used.
two_shades

One Green To Rule Them All

Let’s use #23e066 as the main green colour. It adds a little more contrast that will be appreciated by users. Here are some examples of this minor update:
examples

If it works for you, I will updated all styles with the green in Zeplin.

Gradients

Let’s stick to the following structure: a modified colour on the left and the original colour on the right. Here are some examples:
gradient_structure

Current implementation needs a fix because both colours are modified and the original colour barely impacts the way the gradient will look like.
gradient_issue

Hover

Let’s fix hover effect. I believe the issue is about using absolute lighten values instead of relative ones. That might be the reason why the hover effect looks so rough. Let’s be sure to use scale-color instead. I'm good to go with any other solution as long as it solves the issue. Please compare:
hover_and_pressed

Pressed

Let's tweak pressed effect a little and make it less dark: use 7% darken instead of 10%. Please note that these changes are not in Zeplin, just a tweak on the go, but I'd change the source files if you agree with that :)

@asvae asvae added the BUG Something isn't working label Sep 23, 2019
@asvae asvae added this to the 1.0 milestone Sep 30, 2019
@Kreezag Kreezag self-assigned this Oct 1, 2019
@asvae asvae closed this as completed in #52 Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants