Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Changing Python version comparison from StrictVersion to LooseVersion #28

Merged
merged 1 commit into from Sep 27, 2016
Merged

Conversation

hhslepicka
Copy link
Contributor

Due to some bugs with weird Python versions, e.g. 2.7.12+.

As reported by @arkilic, see https://gist.github.com/arkilic/77443a88a77abce029064c6cc21ca828, after the changes he faced an error when compiling pvaPy under system python in ubuntu 16.04 LTS.

@arkilic, please test again with your system that was presenting the error. I did some tests and it works for me here.

…rsion due to some bugs with weird Python versions, e.g. 2.7.12+
@epics-jenkins
Copy link

Can one of the admins verify this patch?

@ghost
Copy link

ghost commented Sep 27, 2016

Tested locally, fixes the issue mentioned

@ralphlange
Copy link
Contributor

retest this please

@hhslepicka
Copy link
Contributor Author

@ralphlange , I retested it here on my environment and it works. Would you be able to provide more details? Thanks

@anjohnson
Copy link
Member

@hhslepicka The wording of @ralphlange 's message was actually an instruction to our Jenkins CI-server to tell it to go ahead and run the tests on your pull-request, he was responding to the earlier message from @epics-jenkins . For security reasons Jenkins will only test-build a pull-request from a developer who it doesn't know when instructed to do so by one who it does.

Ralph, could adding @epics-jenkins at the start of the message be made to work? That should reduce the confusion about who it's addressing. It would also be helpful if the original message from Jenkins could tell us exactly what we need to say to trigger the pull-request build, I can never remember it...

@hhslepicka
Copy link
Contributor Author

Ooops... I'm sorry about that! It is the first time that I face this process.
Thanks for clarifying @anjohnson and I'm sorry about the message @ralphlange .

@sveseli sveseli merged commit 5c39249 into epics-base:master Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants