Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link in Native ESM Decision Doc 404s #210

Closed
aydrian opened this issue Jun 21, 2023 · 8 comments
Closed

Link in Native ESM Decision Doc 404s #210

aydrian opened this issue Jun 21, 2023 · 8 comments

Comments

@aydrian
Copy link

aydrian commented Jun 21, 2023

In the Native ESM Decision Doc, You link to the talk More than you want to know about ES6 Modules, however the link https://kentcdodds.com/talks/more-than-you-want-to-know-about-es-6-modules 404s.

@kentcdodds
Copy link
Member

Hmmm, it seems to work for me. What do you see?

@aydrian
Copy link
Author

aydrian commented Jun 21, 2023

Maybe I was just confused on the layout. The title of the page is "404: Talk Not Found", but I did see it with all the other cards, it was on the right side. I thought I needed to click on the talk title which took me to the top of that same page with the same time. I'm now seeing in that talk card there are links. It's just not what my eyes were drawn to.

@onemen
Copy link
Contributor

onemen commented Jun 21, 2023

404

I can confirm this issue.

the talk exist [More than you want to know about ES6 Modules](https://kentcdodds.com/talks/more-than-you-want-to-know-about-es-6-modules) but the link not working and we get the list of all the talk

@aydrian, are you on Windows ?

@kentcdodds
Copy link
Member

Oh yeah, I'm getting that also. Maybe it has to do with the recent v2 meta changes. I also noticed some viewport issues on my phone which could be related.

@onemen
Copy link
Contributor

onemen commented Jun 21, 2023

i am checking it right now

@onemen
Copy link
Contributor

onemen commented Jun 21, 2023

@kentcdodds,

i've test the site with the latest commit before v2 meta and it work.

do you want to revert the changes until we find the regression?

@kentcdodds
Copy link
Member

Sure 👍

@kentcdodds
Copy link
Member

Deploying the revert right now. kentcdodds/kentcdodds.com@9c45453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants