-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SENTRY_PROJECT missing from deploy.yml #719
Comments
That approach works, but did you check the docs? https://github.com/epicweb-dev/epic-stack/blob/main/docs/monitoring.md#setting-up-the-sentry-vite-plugin |
hey @kentcdodds , thank you for the fast reply. Your message is too succinct for me to understand it. What do you mean by check the docs? is what I'm seeing in your repo normal ? https://github.com/epicweb-dev/epic-stack/actions/runs/8945529892/job/24574702633 |
Ah, I misunderstood you. Yeah, we'll want to add a note in the docs about updating the environment variables in GitHub CI and update the action as you said. Could you make a PR? |
Im glad Im not the only one banging my head against the wall here, ha! I am having the same issues and now I see that epicweb.dev is getting same Sentry errors I have added this to the deploy.yml and I'm still getting the same errors in the build log
|
The reason you are getting those errors in the console is because you have a browser extension or some browser functionality that is blocking sentry. The reason we're getting those errors in the build is because I forgot to set those environment variables. I'll get that done later. |
Thanks for the clarification Kent. You are correct, running Incognito there are no console or network errors. Do you know what is causing the sentry-vite-plugin warning about no org provided? |
You need to add those environment variables. You can either add them here: epic-stack/.github/workflows/deploy.yml Line 178 in 973d834
And set those in your actions like you do the private token. Or you could hard-code them in the Dockerfile because those values aren't private. The docs could probably be updated on this I think. |
I think I have it working properly now. I would agree the monitoring doc is a little confusing. In case you missed my first comment, I had added the following to https://github.com/epicweb-dev/epic-stack/blob/973d834a32cf4318e2657148a27f805047ed66d3/.github/workflows/deploy.yml#L174
I made a change in https://github.com/epicweb-dev/epic-stack/blob/973d834a32cf4318e2657148a27f805047ed66d3/other/Dockerfile#L29 to
And that seems to work or at least the build errors are gone lol and Sentry is monitoring my app. |
Would you be interested in making a PR to fix things? |
Done :) |
It should have been aprox a month or so that you are not getting any sentry info for epic-stack
Here is the error message from epic-stack own repo
https://github.com/epicweb-dev/epic-stack/actions/runs/8945529892/job/24574702633
The solution I went with on my own project:
The text was updated successfully, but these errors were encountered: