SSR presence #153
Merged
SSR presence #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an onRequest handler to partykit to get the current presence on a regular HTTP request. We use that response to populate initial state during SSR, and then takeover with websockets after render. (Additionally, this removes some config and files that aren't used anymore from the presence package)
threepointone
commented
Oct 17, 2023
| @@ -15,6 +15,21 @@ export function usePresencePreferences() { | |||
|
|
|||
| type User = Pick<ReturnType<typeof useUser>, 'id' | 'name' | 'avatarUrl'> | |||
|
|
|||
| export async function getPresentUsers(): Promise<User[]> { | |||
| const presence = (await fetch( | |||
| // 'http://127.0.0.1:1999/party/epic-web-presence', | |||
There was a problem hiding this comment.
node 18 has issues fetching from localhost, so we switch to 127.0.0.1 instead
threepointone
commented
Oct 17, 2023
kentcdodds
reviewed
Oct 17, 2023
packages/presence/src/server.ts
Outdated
Comment on lines
65
to
67
| if (req.method === 'POST') { | ||
| return Response.json(this.getPresenceMessage().payload) | ||
| } |
There was a problem hiding this comment.
Can we do a little bit of routing here so it can have a more descriptive path?
There was a problem hiding this comment.
yes we can! But I discovered a bug, that we need to land this fix for partykit/partykit#503 Might be a day before that happens.
There was a problem hiding this comment.
actually, I have a workaround that doesn't need us to land that fix. gimme a min.
There was a problem hiding this comment.
aight, whaddaya think?
|
馃帀 This PR is included in version 2.45.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an onRequest handler to partykit to get the current presence on a regular HTTP request. We use that response to populate initial state during SSR, and then takeover with websockets after render.
(Additionally, this removes some config and files that aren't used anymore from the presence package)
@kentcdodds I tested that this "works", but I seem to have found myself in some weird cyclic typescript definition hell 馃槙