-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weight delays separately #630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
previously approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like that this option is now used at a more granular level, allowing for more control on the user side. I left a few suggestions in the documentation. Also, I think your choice of "weight" is correct and descriptive.
Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* weight delays separately * update snapshot (rounding?) * add news item * add PR number and reviewer Co-authored-by: James Azam <james.azam@lshtm.ac.uk> * rephrase documentation --------- Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* weight delays separately * update snapshot (rounding?) * add news item * add PR number and reviewer Co-authored-by: James Azam <james.azam@lshtm.ac.uk> * rephrase documentation --------- Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #519.
It adds a
weight_priors
argument (having realise that "weigh" is the wrong verb!) togeneration_time_opts()
,delay_opts()
andtrunc_opts()
. I'm not sure this is a super clear argument name but I haven't been able to come up with a better one.The
..._opts()
functions then add this to the delay distributions as an attribute. This necessitated some additional attribute copying in other parts of the code which is not great as it affects stability of the code but perhaps unavoidable.Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request