Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up functions to get stan models #642

Merged
merged 11 commits into from
Apr 25, 2024
Merged

tidy up functions to get stan models #642

merged 11 commits into from
Apr 25, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Apr 24, 2024

Description

This PR closes #641 and tidies up a few more documentation / internal functions related to loading the stan models.

A joint news item was added for the previously missing PR #537 and this one.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk
Copy link
Contributor Author

sbfnk commented Apr 25, 2024

Only affects internal functions, double-checked myself and all checks pass - will merge.

@sbfnk sbfnk merged commit fbb5f98 into main Apr 25, 2024
10 checks passed
@sbfnk sbfnk deleted the cmdstan-pass-options branch April 25, 2024 14:16
sbfnk added a commit that referenced this pull request May 3, 2024
* tidy up functions to get stan models

* add news item

* add PR number

* remove ellipsis passing

* minor doc improvements

* add default cmdstan model

* clarify stan model options

* only arg_match backend if needed

* match backend before usage

* handle backend correctly in opts

* remove backend from dist_fit
sbfnk added a commit that referenced this pull request May 3, 2024
* tidy up functions to get stan models

* add news item

* add PR number

* remove ellipsis passing

* minor doc improvements

* add default cmdstan model

* clarify stan model options

* only arg_match backend if needed

* match backend before usage

* handle backend correctly in opts

* remove backend from dist_fit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to pass options to cmdstanr::cmdstan_model
1 participant