Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerance to equality tests #100

Merged
merged 1 commit into from Oct 25, 2023
Merged

Add tolerance to equality tests #100

merged 1 commit into from Oct 25, 2023

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Oct 24, 2023

Hopefully fixes #99

I don't have access to a noLD platform right now but I can give r-hub a spin

@sbfnk
Copy link
Collaborator

sbfnk commented Oct 25, 2023

Not seeing any arm64 (is that the same as noLD?) platforms in https://github.com/r-hub/rhub2/blob/v1/actions/rhub-setup/platforms.json

That said I agree that this should fix things so will send to CRAN.

@sbfnk sbfnk merged commit 6d801da into main Oct 25, 2023
11 of 14 checks passed
@sbfnk sbfnk deleted the expect-tolerance branch October 25, 2023 07:32
@Bisaloo
Copy link
Member Author

Bisaloo commented Oct 25, 2023

Not seeing any arm64 (is that the same as noLD?) platforms in r-hub/rhub2@v1/actions/rhub-setup/platforms.json

No, it's not the same but the errors (more errors actually) were also visible on the CRAN noLD platform so it's probably a good test case.

@sbfnk
Copy link
Collaborator

sbfnk commented Oct 25, 2023

No, it's not the same but the errors (more errors actually) were also visible on the CRAN noLD platform so it's probably a good test case.

Ah yes I only saw this now and agree. Not having much joy with rhub due to missing pandoc-citeproc but can just submit as is.

@sbfnk
Copy link
Collaborator

sbfnk commented Oct 25, 2023

All good when sent manually to rhub with nold:
https://builder.r-hub.io/status/socialmixr_0.3.1.tar.gz-174a455351174d3ab45ce8270da09444

Thanks again!

@sbfnk
Copy link
Collaborator

sbfnk commented Oct 30, 2023

This did the trick - all checks passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN checks failing
2 participants