Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elda 2.0.1 computes incorrect page URI if api:base is null or empty #220

Open
skwlilac opened this issue Oct 29, 2019 · 1 comment
Open
Assignees

Comments

@skwlilac
Copy link
Contributor

The root cause of a problem reported on linked-data-api-discuss[1] turns out to be that in the case where the api spec does not set an api:base (and in the case where api:base is set to the empty string) Elda computes the incorrect value for the request page.

The problem lies in RouterRestlet and was introduced by commit

309611e

as part of the work to make elda responsive to forwarding headers.

The correct behaviour in these cases is for elda to use the request URI as received and to override protocol and host with values from the forwarding headers if present.

[1] https://groups.google.com/d/msg/linked-data-api-discuss/9qtbPYCAutQ/7FpxxkQoDwAJ

@skwlilac
Copy link
Contributor Author

An alternative fix to the presenting issue is to specify and api:base value in the standalone api spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants