Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources Requests for Staging Job #2286

Closed
riqueps opened this issue May 5, 2023 · 1 comment · Fixed by #2384
Closed

Resources Requests for Staging Job #2286

riqueps opened this issue May 5, 2023 · 1 comment · Fixed by #2384
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@riqueps
Copy link

riqueps commented May 5, 2023

Is your feature request related to a problem? Please describe.

Currently the Staging job does not have Resources requests section.

For standard k8s clusters (eks managed nodes, gke standard), this allows the pod consume how much resource it wanna, and sometimes it make the node became unresponsive due the lack of resources.

For gke autopilot clusters, when resources requests is not specified, the gke sets the default resource requests, causing the staging job failing due BackoffLimitExceeded

Describe the solution you'd like

I thought in two possible solutions:

1 - Set a hard coded value on the stage job definition: https://github.com/epinio/epinio/blob/main/internal/api/v1/application/stage.go#L524

2 - Expose via helm-chart values, so we can set our own values during the epinio installation and also change it if needed..

stagingJob:
  resources:
    requests:
      cpu: 
      memory: 
@riqueps riqueps added the kind/enhancement New feature or request label May 5, 2023
@enrichman enrichman added this to the v1.9.0 milestone May 10, 2023
@andreas-kupries
Copy link
Contributor

The epinio/helm-charts#428 is not a fix.
However it handles a similar request (annotations, epinio/helm-charts#424)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants