Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an en/ folder? #34

Closed
quantum9Innovation opened this issue Apr 6, 2021 · 2 comments · Fixed by #59
Closed

Adding an en/ folder? #34

quantum9Innovation opened this issue Apr 6, 2021 · 2 comments · Fixed by #59
Assignees
Labels
doc 📜 Improvements or additions to documentation low-priority 🔽 Will be worked on later nightly 🌙 Nightly builds or releases

Comments

@quantum9Innovation
Copy link
Member

Right now both pdoc docs and translations are stored on the root folder in gh-pages. There are two problems with this:

  1. Modules with the same names as language codes will cause improper translations
  2. Sub-modules are not being deleted
    a) The command that is being run in docs.yml is rm * which only deletes root files
    b) Files inside sub-modules will not be deleted

Possible fix:
Create an en/ folder for English documentation solving (1) and then delete all documentation inside en/ including sub-modules
every time docs.yml is run solving (2).

@quantum9Innovation quantum9Innovation added doc 📜 Improvements or additions to documentation nightly 🌙 Nightly builds or releases low-priority 🔽 Will be worked on later stale Will be worked on ... but slowly labels Apr 6, 2021
@quantum9Innovation quantum9Innovation added this to In progress in Maintenance v2 Apr 6, 2021
@quantum9Innovation quantum9Innovation moved this from In progress to Done in Maintenance v2 Apr 6, 2021
@quantum9Innovation quantum9Innovation removed this from Done in Maintenance v2 Apr 6, 2021
@Quantalabs
Copy link
Member

How would you get nightly docs for Spanish?

@quantum9Innovation
Copy link
Member Author

@mt-gitlocalize will be used to keep track of changes and periodic translations but they won't be nightly or instant--rather they'll be updated each release

@github-actions github-actions bot removed the stale Will be worked on ... but slowly label Apr 15, 2021
@quantum9Innovation quantum9Innovation added this to Low priority in Management v2 Apr 21, 2021
@quantum9Innovation quantum9Innovation removed this from To do in Maintenance v2 Apr 25, 2021
Management v2 automation moved this from Low priority to Closed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc 📜 Improvements or additions to documentation low-priority 🔽 Will be worked on later nightly 🌙 Nightly builds or releases
Projects
No open projects
Management v2
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants