Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace error with warning in chain_sim() #53

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

jamesmbaazam
Copy link
Collaborator

This PR will cause a minor behaviour change in chain_sim() and bump up the R version to accommodate some new base R functions in use in the package. The PR does not fix any raised issues.

Previously, whenever the user specified the serial argument in chain_sim() but also set tree = FALSE, they would get an error. In this PR, we change this behaviour so that when this argument combination occurs, we change tree to TRUE, throw a warning to inform the user about what happened and continue the simulation.

This new behaviour is intended to improve user experience, but if it causes any inconveniences or bugs, please feel free to open an issue.

@jamesmbaazam jamesmbaazam added the enhancement New feature or request label Apr 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #53 (5ee1d10) into main (6f3556a) will increase coverage by 3.40%.
The diff coverage is 100.00%.

❗ Current head 5ee1d10 differs from pull request most recent head 2bf83d8. Consider uploading reports for the commit 2bf83d8 to get more accurate results

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   92.82%   96.23%   +3.40%     
==========================================
  Files           5        5              
  Lines         237      239       +2     
==========================================
+ Hits          220      230      +10     
+ Misses         17        9       -8     
Impacted Files Coverage Δ
R/simulate.r 98.73% <100.00%> (+10.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jamesmbaazam jamesmbaazam merged commit 7be58e1 into main Apr 21, 2023
@jamesmbaazam jamesmbaazam deleted the warning_replace_error branch April 21, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants