Replace error with warning in chain_sim() #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will cause a minor behaviour change in
chain_sim()
and bump up the R version to accommodate some new base R functions in use in the package. The PR does not fix any raised issues.Previously, whenever the user specified the
serial
argument inchain_sim()
but also settree = FALSE
, they would get an error. In this PR, we change this behaviour so that when this argument combination occurs, we changetree
toTRUE
, throw a warning to inform the user about what happened and continue the simulation.This new behaviour is intended to improve user experience, but if it causes any inconveniences or bugs, please feel free to open an issue.