Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to the Vacamole model #203

Merged
merged 5 commits into from Mar 20, 2024
Merged

Conversation

pratikunterwegs
Copy link
Member

@pratikunterwegs pratikunterwegs commented Mar 20, 2024

This PR is related to #143:

  1. Corrects the implementation of the Vacamole model C++ code by changing to a stricter accessor for the model infection parameter map;
  2. Enables the use of rate interventions on all model infection parameters;
  3. Enables the use of time-dependence on all model infection parameters;
  4. Adds representative tests that check the statistical correctness of the vaccinated compartment, and that check that time-dependence works as expected on optional parameters not found in the default model.

This PR overrides #144 which restricted interventions to a smaller subset of parameters.

@pratikunterwegs pratikunterwegs self-assigned this Mar 20, 2024
@pratikunterwegs pratikunterwegs added Bug Something isn't working Enhancement ODE model Related to the ODE models in epidemics labels Mar 20, 2024
Comment on lines +175 to +177
checkmate::assert_numeric(transmission_rate_vax, lower = 0, finite = TRUE)
checkmate::assert_numeric(hospitalisation_rate_vax, lower = 0, finite = TRUE)
checkmate::assert_numeric(mortality_rate_vax, lower = 0, finite = TRUE)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further correction to allow these rates to have any positive finite value; previously they were treated as proportions of the rate for unvaccinated individuals.

@pratikunterwegs
Copy link
Member Author

Merging this hotfix now.

@pratikunterwegs pratikunterwegs merged commit ce8e92b into main Mar 20, 2024
13 checks passed
@pratikunterwegs pratikunterwegs deleted the vacamole-corrections branch March 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working ODE model Related to the ODE models in epidemics
Development

Successfully merging this pull request may close these issues.

None yet

1 participant