-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vignette to compare with {finalsize} #33
Comments
The vignette includes a couple of simple code examples to compare the two approaches. I noticed a couple of differences in the implementation that might be good to think about.
|
Have had a look through, and useful to see them side-by-side to understand structure/naming etc. A few additional thoughts:
|
Thanks @BlackEdder, will you keep working on this vignette or should I take this further and make a PR?
Thanks - maybe 'demo_group' is a good compromise between the two packages, and between clarity and brevity. That said {finalsize} is on CRAN so perhaps adopting 'demo_grp' in {epidemics} is safer than changing it in both packages.
Yes, it is scaled internally using
I had not really thought about it, but I can convert it to an issue and a relevant test for correctness. |
Thanks @adamkucharski - I think being able to answer the temporal questions, and the effect of interventions etc is probably the key aspect, but others are good to mention too. Speaking of temporal questions, would it be useful to have helper functions that help get the timing and size of the epidemic peak (optionally by age group)? |
Yep, size in particular often useful as output metric, particularly for healthcare requirements, deaths etc. (e.g. Table 2 in early COVID modelling) and tables in Roadmap analysis. |
Thanks - we do have |
Might be most efficient if you would be willing to take this further. Agreed that it would be good to explain in the text, what the main differences are between the two packages. I would hazard that final size is faster, but if you need dynamics over time and/or interventions/vaccinations that happen over time, you should use the epidemics package. |
Okay thanks, will do. |
This PR is to request a vignette that compares the final size calculations from {epidemics} against those from {finalsize}, to show the effect of implementing interventions and vaccination regimes.
The text was updated successfully, but these errors were encountered: