Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove piping operators #26

Closed
thibautjombart opened this issue Sep 26, 2022 · 4 comments
Closed

Remove piping operators #26

thibautjombart opened this issue Sep 26, 2022 · 4 comments
Labels
question Further information is requested

Comments

@thibautjombart
Copy link

The code currently uses some piping operators %>%. I would recommend not using them in packages as they can make debugging quite hellish.

@joshwlambert joshwlambert added the question Further information is requested label Sep 28, 2022
@joshwlambert
Copy link
Member

There was some ambiguity before as to whether the opposition was specifically to %>%, and not |>, or whether the opposition was to using any pipes throughout the package. What are peoples preferences?

@thibautjombart
Copy link
Author

Good point, I have never used the base pipe to be perfectly honest. Not sure how debugging goes with it.

@Bisaloo
Copy link
Member

Bisaloo commented Oct 17, 2022

The native pipe should not be used here as it will introduce a dependency on more recent R versions, which our users might not have access to just yet.

@joshwlambert
Copy link
Member

All pipes have now been removed from the package (as well as any dependency on an R version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants