Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epicurves description in transmissibility report #139

Closed
CarmenTamayo opened this issue Apr 9, 2024 · 4 comments
Closed

Epicurves description in transmissibility report #139

CarmenTamayo opened this issue Apr 9, 2024 · 4 comments

Comments

@CarmenTamayo
Copy link
Contributor

The report template for transmissibility currently describes that the section "Epidemic curves" generates these curves with or without stratification, however the provided code and resulting epicurves only show stratified epicurves and total no. of cases

@Bisaloo should we also add the total incidence across regions, or remove the "without stratification" bit?
I think we could simply add an overall epicurve/total no. of cases graph to the existing ones

@Bisaloo
Copy link
Member

Bisaloo commented Apr 9, 2024

@Bisaloo should we also add the total incidence across regions, or remove the "without stratification" bit?

I don't have a strong preference. Both options sound reasonable and I'm happy to let you decide.

@CarmenTamayo
Copy link
Contributor Author

Hi @Bisaloo , I've noticed that on the package's vignette there's indeed an epicurve with overall cases, but this seems to be no longer available on the current template's code- was there a reason for this can you remember? I'll try find the og code

@CarmenTamayo
Copy link
Contributor Author

Fixed in #144

@Bisaloo
Copy link
Member

Bisaloo commented Apr 23, 2024

Context: this was removed from incidence2 for a while but have been reintroduced in reconverse/incidence2@cda7bf0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants