Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Feature request: hide MRs based on their latest pipeline status #9

Open
stoyicker opened this issue Jun 23, 2020 · 7 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@stoyicker
Copy link

Hey, nice little tool. thanks for the effort. I would like to request hooking onto the "filter" view for gitlab to offer hiding MRs based on: WIP status and latest pipeline status.

@EpocDotFr EpocDotFr added the enhancement New feature or request label Jun 26, 2020
@EpocDotFr
Copy link
Owner

Hello, thank you for your interest!

Looks like you already can filter MRs depending on their WIP status:

Capture d’écran 2020-06-26 à 15 27 03

This filter has been introduced in GitLab 11.4.0.

About the latest pipeline status filter: I only took a quick look but looks like it's possible! I however can't give you a release date, though.

@EpocDotFr
Copy link
Owner

EpocDotFr commented Jun 26, 2020

Note: the GitLab API doesn't allow to filter MRs by pipeline status upwind. So the only possible thing I can do is to hide MRs based on the pipeline status although these MRs already have been displayed to the user.

@stoyicker
Copy link
Author

Sorry about the MR thing, this gitlab version got deployed to our infra literally the day after I wrote this xD Yeah I know about that limitation, but I think hiding them by directly altering the site to remove "out-filtered" ones should be fine. It's not like regular desktop gitlab users are going to be bothered about bandwidth and I don't know of any major mobile browsers that support add-ons.
I understand about the release date, thank you for your effort!

@EpocDotFr EpocDotFr changed the title Feature request: hide MRs based on criteria not offered by GitLab Feature request: hide MRs based on their latest pipeline status Jun 29, 2020
@EpocDotFr EpocDotFr added this to the 1.6 milestone Jun 29, 2020
@EpocDotFr
Copy link
Owner

EpocDotFr commented Jun 30, 2020

Investigated a bit further: it's going to be very hard, and even impossible to hook into the filter component for several reasons. Too bad, would have been cool.

I however found another possible solution that is somewhat easier to implement: add a dropdown menu next to the sort dropdown menu:

image

The selected value would be remembered by storing it in the local storage.

@stoyicker
Copy link
Author

stoyicker commented Jul 1, 2020

I'm no webdev at all and don't know what stack you're using, but I remember I did a chrome extension for google translate (https://github.com/stoyicker/Copy-Translation) where I just manipulated the site html directly, so I don't really see why you couldn't alter gitlab's filter to basically merge the dropdown you're proposing into it. But I don't know what stack you're using and barely any web development, so I think you should trust your own criteria. the dropdown solution looks perfectly fine to me

@EpocDotFr
Copy link
Owner

Is it OK to put this pipelines status filter in the options page of the extension?

Adding this filter in the page itself (like in my above screenshot) means I have to write a system to persist preferences on a per-Gitlab-project basis, which is something I'd like to introduce later (because if I introduce such a feature, I'd like all the other options to be persisted the same way, which is a bit of work).

@stoyicker
Copy link
Author

stoyicker commented Jul 31, 2020

Well, it seems prettier the way you initially suggested, and it may be a bit hidden for regular users that don't read this issue, but obviously as far as I am concerned, it's fine

@EpocDotFr EpocDotFr modified the milestones: 1.6, 1.7 Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants