Support for .aac audio files

[Skydef]

I've opened this issue mainly for clarification. If I understand correctly parsing of .aac files is currently not supported, because of taglib not fully supporting aac? In a taglib pull request regarding aac (ADTS) support one of the developers mentions that taglib can partially work with aac files when using MPEG::File (taglib/taglib#856 (comment)). "They will not get properties, but at least, they can edit ID3v1, ID3v2 and APE tags on the AAC files". With this in mind would Lms be able to support .aac or is is not feasible or not planned?
At the moment I get "Cannot parse file" for all .aac (ADTS) files in my library. But aac in MPEG-4 container (.m4a) works. If .aac support is not feasible or requires a lot of work I will just remux my files to .m4a, so it won't be a big problem for me.

[epoupon]

Well indeed TagLib cannot read these files without some hacks. And as it is said in the linked issue, it looks like TagLib cannot extract audio properties, like duration, which is really needed by LMS to properly work (I have not checked myself if this is true)
Technically, we could hack this issue since LMS internally supports both ffmpeg and TagLib to parse audio files (ffmpeg parser is quite outdated though, you can try to parse a file using the command line tool lms-metadata, you will get an idea of what the parser can actually extract)

[stkw0]

Seems the situation may be better now? taglib/taglib#856 (comment)

[epoupon]

Indeed, looks like better now! Thanks for the reminder

[epoupon]

It will be supported in the docker image v3.53.0, as it embeds a newer TagLib (v2.0.1) handling this properly

[stkw0]

This means it doesn't required any change on LMS itself? That is, distros packaging lms only need to depend on TagLib >= 2.0.1 to have this fixed?

[epoupon]

I haven't checked the exact package version required.
Just noticed it now works with 2.0.1, and does not work with 1.13

[epoupon]

And yes, the code to support AAC was already present in lms itself.