EPrints::Update::Static exposes filesystem information

[denics]

EPrints::Update::Static exposes filesystem when creating auto.js and auto.css this can be avoided by commenting line 270, or adding a test if we are debugging

[mpbraendle]

I don't agree with this commit. The path is useful information, especially for debugging.

[phluid61]

Perhaps it would be better to include only the file path after .../auto/ (e.g. 20_prototype.js)

We have experimental code in our repository that minifies auto.js and auto.css as they're being generated; I'm pretty sure I did a similar thing there (shrinking source filenames), but I don't have access to the source repository right now as I'm out of office.

[phluid61]

I was able to recreate the branch against 3.3: https://github.com/QUTlib/eprints/tree/feature/auto-minifiers

The relevant part of the diff is essentially:

-       print $fh "\n\n\n/* From: $path */\n\n";
+       print $fh "\n/*+$fn*/\n";

[denics]

Thanks Matthew, this solution is good enough to avoid exposing the filesystem and should be used as a quick fix.
However, a perhaps more elegant solution would be to use the noise parameter like in https://github.com/denics/eprints/commit/a761481a1cd816ed317ec15a6d6994d5dffed009 , tell me what do you think. If you guys agree, I will push the commit here.

[mpbraendle]

I think Matthews solution is fine.
noise or verbose would be only active during the generation of the auto.* files.
However, if you want to debug the JavaScript (in a test or live environment) using the developer tools of the browser, it is good to know from which file the code stems from. Why would I need to always run a generate_static in order to know the origin of the code?

[denics]

Because you are supposed not to work directly on your production server.
If you have a git environment, you can have your development server with noise = 4 and your production server with noise = 0.

[jesusbagpuss]

Does the 'developer mode' alter the noise?
As I understand things, it causes the auto files to be recompiled with each request. It could also be used to put the full path in if it is on?

[mpbraendle]

Of course your first statement is clear to me. But did you try out noise = 4 once? You wouldn't see the forest anymore because of so many trees.

[denics]

For example, in my development machine I have a file called archive/{archive}/cfg/cfg.d/0_devel.pl where I set the level of noise. I understand, perhaps setting the loglevel to 4 is too much, maybe 3 would be better, but I strongly encourage the use of a $debug variable than having hardcoded print here and there. especially for highly exposed servers.

[denics]

Sorry, I just realized I forgot the comment line in my pull https://github.com/denics/eprints/commit/2175f0f597b7c3e40d255afe420219226a920243