Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting ignore_login_ip to true by default if HTTPS enabled #339

Closed
drn05r opened this issue Aug 2, 2023 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@drn05r
Copy link
Contributor

drn05r commented Aug 2, 2023

ignore_login_ip as a configuration setting is a historic feature to improve security of logged in sessions. WIth HTTPS this is rather superfluous but is still enabled by default and can present issues to users who sit behind some sort of round-robin NAT where their IP address can quickly change between requests. It may be worth keeping ignore_login_ip enabled if HTTPS is not enabled but it creates more issues than it solves if HTTPS is enabled.

@drn05r drn05r added enhancement New feature or request question Further information is requested labels Aug 2, 2023
@drn05r drn05r added this to the 3.4.6 milestone Aug 2, 2023
@drn05r drn05r self-assigned this Aug 2, 2023
@jesusbagpuss
Copy link
Contributor

I think this is a sensible option / update, especially now there are services such as LetsEncrypt that offer free HTTPS certificates.

When I first read the title of this question, I mentally parsed it as:
ignore login ip if a user is logging in over https
rather than:
set this global system param if the configuration supports https

The first of these feels slightly less risky - but I think it's marginal - so happy with either interpretation.

@drn05r
Copy link
Contributor Author

drn05r commented Aug 3, 2023

I have reviewed the code and it is only referenced in one place so I was planning to just modify the if statement to say ignore_login_ip or securehost is set.

@drn05r drn05r closed this as completed in bfc890d Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants