Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"More input rows" button affects layout of Compound field tables in workflow #378

Closed
drn05r opened this issue Mar 13, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@drn05r
Copy link
Contributor

drn05r commented Mar 13, 2024

If you have a Compound MetaField that has a first column (i.e. sub-field) that is very short then the layout of the table can be affected by the "More input rows" button adding a lot of space around this column. This is because the table is no longer an HTML table but a table of divs. This does not support colspan either as an HTML attribute for a div or by some other CSS approach.

A better way to fix this would be to completely remove this button from the divs table and have it included in a separate div below the table. To fix this, the code in EPrints::MetaField needs to be update to change how it builds this HTML.

@drn05r drn05r added the bug Something isn't working label Mar 13, 2024
@drn05r drn05r added this to the 3.4.6 milestone Mar 13, 2024
@drn05r drn05r self-assigned this Mar 13, 2024
@drn05r drn05r closed this as completed in 590464c Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant