Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate history and provide history digging functions instead #85

Closed
horkhe opened this issue Oct 26, 2012 · 4 comments
Closed

Deprecate history and provide history digging functions instead #85

horkhe opened this issue Oct 26, 2012 · 4 comments

Comments

@horkhe
Copy link
Contributor

horkhe commented Oct 26, 2012

Test writers do not need entire history. They need a convenient way to find out some specific facts about the history like called and num_calls functions. By providing them entire history we kind of forcing them to write custom information retrieval and verification functions.

I believe a better way would be to provide a comprehancive set of history digging functions, such as:

  • verify - a unified version of called and num_calls that allows complex number of calls verification, argument matching using standard Erlang patterns and possibly Hamcrest matchers. It will also support verification of the order in which functions were called;
  • capture - provides a way to retrieve a particular argument value that a particular function was called with.

That probably covers everything a testing human being might need.

@eproxus
Copy link
Owner

eproxus commented Oct 28, 2012

+1

Although history/1 should probably be left since people might want to build their own hacks on top of it (but with the documented caveat that the return format might change in future versions).

@horkhe
Copy link
Contributor Author

horkhe commented Oct 28, 2012

We won't delete it, we will just deprecate it.

@eproxus
Copy link
Owner

eproxus commented Oct 28, 2012

I would like it to stay as not deprecated, perhaps hidden or just "marked" as non-reliable (between versions).

@horkhe horkhe mentioned this issue Feb 21, 2013
@eproxus eproxus modified the milestones: 1.0, 2.0+ Nov 21, 2016
@eproxus
Copy link
Owner

eproxus commented Nov 21, 2016

Closing and documenting in the wiki instead: https://github.com/eproxus/meck/wiki#feature-ideas

Please comment here if you have information or requests to add, and/or want to discuss a PR or possible implementation proposal.

@eproxus eproxus closed this as completed Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants