Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R16A preview - parameterized modules are no longer supported #94

Closed
norton opened this issue Jan 24, 2013 · 4 comments
Closed

R16A preview - parameterized modules are no longer supported #94

norton opened this issue Jan 24, 2013 · 4 comments
Labels

Comments

@norton
Copy link
Contributor

norton commented Jan 24, 2013

I briefly checked if meck can build or not with a preview version of R16A. Parameterized modules will be going away soon. Have you any ideas so far on how to handle this test case? delete it, define macro, etc.

meck/test/meck_test_parametrized_module.erl:1: parameterized modules are no longer supported
meck/test/meck_test_parametrized_module.erl:6: variable 'Var1' is unbound
meck/test/meck_test_parametrized_module.erl:7: variable 'Var2' is unbound

erl --version
Erlang R16A (erts-5.10) [source] [64-bit] [smp:2:2] [async-threads:10] [kernel-poll:false]

Eshell V5.10  (abort with ^G)
1> 
@eproxus
Copy link
Owner

eproxus commented Jan 26, 2013

The "proper" thing to do would be to macro it, but in this case I think it's safe to remove it. Would you mind making a pull request for this?

@norton
Copy link
Contributor Author

norton commented Jan 27, 2013

See this pull request (#95).

On a similar note, I also noticed that meck's README says that agner is the recommended way to install meck. I believe agner is now deprecated and no longer supported.

@eproxus
Copy link
Owner

eproxus commented Feb 6, 2013

Merged #95.

@eproxus eproxus closed this as completed Feb 6, 2013
@eproxus
Copy link
Owner

eproxus commented Feb 6, 2013

I changed README.md to recommend just using rebar for now in 7f26c19.

@eproxus eproxus added the bug label Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants