Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes #2

Open
eps1lon opened this issue Aug 3, 2018 · 0 comments
Open

Changes #2

eps1lon opened this issue Aug 3, 2018 · 0 comments

Comments

@eps1lon
Copy link
Owner

eps1lon commented Aug 3, 2018

Tracking issue for changes to the upstream that go beyond just porting to a monorepo:

  • granular version check for provided typescript module
    • each rule has its own typescript peerDependency
  • tests from Missing tests #1
  • Removed unified-signatures from dtslint.json no implementation for this rule found
  • Fixed no-redundant-jsdoc:
    • filename was noRedundantJsdoc2Rule implying no-redundant-jsdoc2 but the rule name was set to no-redundant-jsdoc
    • no-redundant-jsdoc-2 was enabled while there exists no implementation
    • no-redundant-jsdoc was disabled while there exists a implementation
  • expectRule:
    • removed functionality that looked for the minimal working ts version
      • functionality is not very well documented
      • I also believe that this is something a wrapper for the cli should do (and use binary search)
      • otherwise this is already given by the ability to specify multiple ts version

WIP

  • rewrite dtslint-cli with the following goal:
    • consistent setup with reproducible output:
      • for each ts version create a package from which tslint is run
      • requires tslint version finder for ts version
    • usage with conflicting ts version in devDependencies
    • cli includes two passes over the codebase:
      • one tslint call without expect using own dependencies
      • one tslint call using the ts version described in the typings header and expect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant