Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate functions #51

Closed
emilyws1 opened this issue Sep 8, 2016 · 4 comments
Closed

duplicate functions #51

emilyws1 opened this issue Sep 8, 2016 · 4 comments
Labels
Milestone

Comments

@emilyws1
Copy link
Contributor

emilyws1 commented Sep 8, 2016

Detections_to_catalog and get_catalog are the same source code

detection.write should also write out a catalog as well as a detection file, otherwise the catalog is lost

@emilyws1
Copy link
Contributor Author

emilyws1 commented Sep 9, 2016

catalog objects include detections value and threshold value - would be good to move away from detection objects and get into catalog objects

@emilyws1
Copy link
Contributor Author

Also: should retain the phase-type in the pick information when writing out from match_filter

@calum-chamberlain calum-chamberlain added this to the 0.1.3 milestone Sep 16, 2016
@calum-chamberlain
Copy link
Member

Great suggestions, will add.
RE the duplicate functions: I will remove one of them and think about what to do with the others once moved away from detection objects...
See PR #43 which is going to implement objects within EQcorrscan that handle the detections (as a Family class), which will have read/write and more metadata handling (so you can track which template was used to make the detection, and the changes in correlations between match-filter and lag-calc stages).
:-)

@calum-chamberlain
Copy link
Member

Finished this and these things will be in 0.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants