Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive Performance Issue in Firefox #9

Closed
emkayy opened this issue Mar 2, 2016 · 10 comments
Closed

Massive Performance Issue in Firefox #9

emkayy opened this issue Mar 2, 2016 · 10 comments

Comments

@emkayy
Copy link

emkayy commented Mar 2, 2016

The site http://elementqueries.com/ is almost unusable due to performance problems.
Scrolling has a huge delay.
It's a nice concept, but I wouldn't use it in production!

@tomhodgins
Copy link
Contributor

Hi emkayy! Thanks for your interest, we've been using this in production for months now and there haven't experienced performance issues in Firefox until this morning, when I got a tweet this same issue.

I can reproduce it in FF 44 here as well, has something about Firefox changed recently?

I believe this is happening because Firefox is recalculating the styles too enthusiastically on scroll. I'm going to test the nightly versions of Firefox now to see if they've resolved what's going on already.

I've just investigated this in today's Firefox nightly build and it's smooth as butter, so I don't know why it broke, or what versions other than FF44 and FF46 that are affected, but it seems Mozilla has already fixed it upstream and we just have to wait for this broken build to update to a new version soon. Actually, you should test it out in Firefox Nightly, it's really fast there!! (min says it's FF47)

In the meantime while we wait for firefox to update, EQCSS still works great in IE8 (and every other browser) if you want to play around with it!

@tomhodgins tomhodgins reopened this Mar 2, 2016
@suprsidr
Copy link

suprsidr commented Mar 2, 2016

I believe this is happening because Firefox is recalculating the styles too enthusiastically on scroll.

Debounce it man!

@suprsidr
Copy link

suprsidr commented Mar 4, 2016

@WilliamVercken
Copy link

I tested on firefox 47 (windows 10), and I have issues too on scrolling.

@tomhodgins
Copy link
Contributor

We're still thinking about how best to implement this, and I'm hoping we can have something in place within the next week 👍

@tomhodgins
Copy link
Contributor

Aw yeah, check this out @emkayy & @WilliamVercken! Here's what we came up with after thought & testing: https://github.com/eqcss/eqcss/releases/tag/v1.2.0

It's been updated in NPM, so it should be available on cdnJS shortly!

Let me know if this fixes your problem :)

@tomhodgins
Copy link
Contributor

After testing I'm going to go ahead and close this one now! Everything's looking smooth as butter :)

@smajl
Copy link

smajl commented Jul 11, 2016

@tomhodgins Demo site http://elementqueries.com/ (currently with 1.2.1), FIrefox 47.0.1, Windows 8.1. Huge lags when scrolling inside elements, sorry. This seems not resolved to me. :( Can I provide some other environment info?

EDIT: Tested on another machine running Windows and Firefox. Lag confirmed.
EDIT2: Seems like everything lags: scrolling the page or elements, typing, resizing, adding elements, etc. Really unusable.

@DavidOliver
Copy link

The demo page performance is not good for me in Firefox 48, Ubuntu, on a fairly beefy machine. There seems to be a very noticeable pause every half a second or so when scrolling or interacting with elements.

Very interesting project, by the way. I hope to try it out soon. Thanks!

@myfonj
Copy link

myfonj commented Aug 26, 2016

Firefox generally suffers while getting ANY style updates, even when <style> element content value "changes" to the same as before. I proposed some optimisations for fixing this issue in https://github.com/eqcss/eqcss/pull/22/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants