Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Scan Process Concurrent #61

Closed
bbertucc opened this issue Aug 4, 2022 · 2 comments
Closed

Make Scan Process Concurrent #61

bbertucc opened this issue Aug 4, 2022 · 2 comments
Labels
bountied https://bbertucc.notion.site/Bug-Bounties-37cb0c61fb2d4bb984a78cc6e4b4aa56 enhancement New feature or request

Comments

@bbertucc
Copy link
Collaborator

bbertucc commented Aug 4, 2022

Currently, we send a URL to web services in a foreach loop.

That means we have to wait to receive the output from the web service before we can add alerts.

To speed things up, we should send multiple URLs to the web service at once.

To do that, we would need to add $integration_alerts($page) function in an async loop.

The winner of this bounty must implement a concurrent process that sends multiple URLs to integrations without waiting for previous URLs to be processed.

Feel free to add third-party integrations like AMP, which should be added via Composer.

You should not use added PHP extensions.

Please pull from the mvp1.2-controller_scanning branch.

Winning solutions will be judged the solution's "readability" and performance.

Winner gets $333 to a charity or PayPal/Venmo account of their choice.

Good luck!

@bbertucc bbertucc added bountied https://bbertucc.notion.site/Bug-Bounties-37cb0c61fb2d4bb984a78cc6e4b4aa56 enhancement New feature or request labels Aug 4, 2022
@ebertucc
Copy link
Collaborator

Made a PR with the first pass at implementing this, along with an accompanying rewrite of the Little Forest integration. (Still need to rewrite the Wave integration.)

Introduces a Composer dependency on Guzzle and changes the API for integrations, which doesn't seem like too big a problem as only Little Forest and Wave have been written so far.

Questions/comments welcome.

@bbertucc
Copy link
Collaborator Author

You got the bounty @ebertucc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bountied https://bbertucc.notion.site/Bug-Bounties-37cb0c61fb2d4bb984a78cc6e4b4aa56 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants