Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky UrlExists test #711

Closed
pattonwebz opened this issue Jul 11, 2024 · 2 comments
Closed

Fix flaky UrlExists test #711

pattonwebz opened this issue Jul 11, 2024 · 2 comments

Comments

@pattonwebz
Copy link
Member

There is a test at: /tests/phpunit/helper-functions/UrlExistsTest.php:20

It makes a request to an external site (httpbin) to retrieve an image and check the url exists. The test is flaky though and sometimes the request times out or fails.

Either remove the test; find a different, more reliable, external service; or add a retry logic.

@SteveJonesDev
Copy link
Member

@pattonwebz, doesn't this PR fix this issue? #713

@pattonwebz
Copy link
Member Author

@SteveJonesDev yeah I must have not tagged it in the PR summary.

Fixed by: #713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants