Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor monitoring package #25

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

equals215
Copy link
Owner

@equals215 equals215 commented May 25, 2024

  • The monitoring routine is now working with an operator pattern like the dashboard, which enable us to control the basic functions of monitoring inside other packages such as server
  • To my knowledge it didn't introduce any race-cond as the operator is mutexed and locked for every read/write operation on non-mutexed field
  • Also nil pointer deref should happen as the pointers susceptible of being nil are checked

Gotta work on :

  • Clarifying timeserie flow
  • Refactor timeserie code
    • Do it well
  • Create an alerting decision engine based on config.*Threshold values (good idea?)

The monitoring routine is now working with an operator pattern like the dashboard, which enable us to control the basic functions of monitoring inside other packages such as server
To my knowledge it didn't introduce any race-cond as the operator is mutexed and locked for every read/write operation on non-mutexed field
Also nil pointer deref should happen as the pointers susceptible of being nil are checked
@equals215 equals215 linked an issue May 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Refactor monitoring package cause the code is astro garbage
1 participant