Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not log EM device objects which may contain sensitive fields #228

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

displague
Copy link
Member

Devices contain "RootPassword" and other fields that may contain sensitive fields. Keep this data out of the logs.

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is part of our security posture; when everyone sees that their passwords are logged, they will stop using them! 😆

Thanks for doing this.

@deitch deitch merged commit 8e0b82b into kubernetes-sigs:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants