move all of informers into single place that uses it #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully this also takes a step towards where @detiber needs it to go. |
displague
reviewed
Feb 10, 2022
deitch
force-pushed
the
isolate-watchers
branch
from
a0a12ea
to
beada76
Compare
|
@detiber can you comment on your work on |
deitch
force-pushed
the
isolate-watchers
branch
from
beada76
to
d3525c1
Compare
|
This is ready for a proper review. Once that is done, I will do a full round of integration testing. |
displague
reviewed
Feb 17, 2022
deitch
force-pushed
the
isolate-watchers
branch
from
d3525c1
to
3b1a4b5
Compare
|
Updated. Ready for another check. |
deitch
force-pushed
the
isolate-watchers
branch
from
3b1a4b5
to
2bc5621
Compare
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
isolate-watchers
branch
from
2bc5621
to
966ee0b
Compare
cprivitere
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the migration in previous PRs to InstancesV2 and especially standard LoadBalancers, we now use the complex informers structure in just one place, EIP ControlPlane Endpoint Manager.
This PR moves all of that into that one place, cleaning up the wrapping
cloud.go.It also removes much of the loop and wrapping complexity, as there is just one place using it.
It also allows us to remove some of the interface types, and simplify the
cloudstructure by referencing the structs directly.Finally, it also sets the resync interval for the informers, allowing us to get rid of the
timerLoop.