General cleanup and updating dependencies #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
detiber
commented
Mar 2, 2022
•
detiber
commented
- Update go version to v1.17
- Update alpine to v3.15
- Update packngo to v0.22.0
- Update k8s dependencies to v0.23.4
- Cleanup unused code, constants, and variables
- fix some lint related issues
- Update error wrapping to use go v1.13+ style error wrapping instead of github.com/pkg/errors
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
|
These are the cleanup changes from #230 |
deitch
approved these changes
Mar 2, 2022
| k8s.io/component-base v0.21.2 | ||
| k8s.io/klog/v2 v2.8.0 | ||
| k8s.io/api v0.23.4 | ||
| k8s.io/apimachinery v0.23.4 |
There was a problem hiding this comment.
Does this create any backwards-compatibility issues with older cluster versions? Or do we just say, "use this version x of CCM for version y of cluster"?
There was a problem hiding this comment.
It shouldn't cause any issues, since client-go has a pretty good track record of backward/forward compatibility
| ) | ||
|
|
||
| require ( | ||
| github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect |
There was a problem hiding this comment.
That's quite the growth in explicit requirements. Why is that?
There was a problem hiding this comment.
It's new behavior in go 1.17 related to how go builds up the dependency graphs for projects: https://go.dev/doc/go1.17#go-command
|
Testing all was clean. Thanks for the cleanup @detiber |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.