Fix issue with services controller when load balancing should be disabled #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
detiber
commented
Mar 2, 2022
Comment on lines
-31
to
-34
| var ( | ||
| validCloud *cloud | ||
| backend *store.Memory | ||
| ) |
There was a problem hiding this comment.
Removing these variables was the easiest way that I could enable testing with different configurations instead of a common shared config.
Comment on lines
+88
to
+101
| func TestLoadBalancerDefaultDisabled(t *testing.T) { | ||
| vc, _ := testGetValidCloud(t, "") | ||
| response, supported := vc.LoadBalancer() | ||
| var ( | ||
| expectedSupported = false | ||
| expectedResponse = response | ||
| ) | ||
| if supported != expectedSupported { | ||
| t.Errorf("supported returned %v instead of expected %v", supported, expectedSupported) | ||
| } | ||
| if response != expectedResponse { | ||
| t.Errorf("value returned %v instead of expected %v", response, expectedResponse) | ||
| } | ||
| } |
There was a problem hiding this comment.
This was previously returning true erroneously, now it properly returns false.
| } | ||
| if response != expectedResponse { | ||
| t.Errorf("value returned %v instead of expected %v", response, expectedResponse) | ||
| } | ||
| } |
There was a problem hiding this comment.
Skipping these because we don't have a k8s client plumbed through for the code paths to be able to run.
Comment on lines
+135
to
+137
| func TestLoadBalancerKubeVIP(t *testing.T) { | ||
| t.Skip("Test needs a k8s client to work") | ||
| vc, _ := testGetValidCloud(t, "kube-vip://") |
There was a problem hiding this comment.
Skipping these because we don't have a k8s client plumbed through for the code paths to be able to run.
This was referenced Mar 2, 2022
Merged
deitch
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run with the load balancer disabled, currently the controller will panic, because we are testing if an interface is nil rather than if the value of the interface is nil).
Replacing the interface types in the cloud struct with the concrete types resolves the issue and as far as I can tell does not impact anything else.